chore(master): merge maint-0.9#590
Merged
tiborsimko merged 4 commits intoreanahub:masterfrom Jul 3, 2024
Merged
Conversation
Member
tiborsimko
commented
Jun 26, 2024
tiborsimko
commented
- feat(helm): allow cluster administrator to configure ingress host (feat(helm): allow cluster administrator to configure ingress host (#588) #588)
- ci(commitlint): improve checking of merge commits (chore(master): merge maint-0.9 #590)
tiborsimko
added a commit
to tiborsimko/reana-workflow-controller
that referenced
this pull request
Jun 26, 2024
* feat(helm): allow cluster administrator to configure ingress host (reanahub#588)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 73.39% 73.57% +0.17%
==========================================
Files 15 15
Lines 1372 1385 +13
==========================================
+ Hits 1007 1019 +12
- Misses 365 366 +1
|
tiborsimko
added a commit
to tiborsimko/reana-workflow-controller
that referenced
this pull request
Jun 26, 2024
feat(helm): allow cluster administrator to configure ingress host (reanahub#588)
mdonadoni
reviewed
Jul 2, 2024
Member
mdonadoni
left a comment
mdonadoni
left a comment
There was a problem hiding this comment.
Could you please update the PR to also include this missing commit? 784efee
Regarding instead the changes to commitlint, could you also add the other changes to ci.yml from this commit? reanahub/reana-workflow-engine-snakemake@690dfc2
feat(sessions): expose user secrets in interactive sessions (reanahub#591) feat(helm): allow cluster administrator to configure ingress host (reanahub#588)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.